Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix typo in doc/tls.md #9566

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in doc/tls.md #9566

wants to merge 1 commit into from

Conversation

nanocloudx
Copy link
Contributor

@nanocloudx nanocloudx commented Nov 12, 2016 •
edited
Loading

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

fix doc/tls.md: line 762 836 1026 e.g., => e.g.

Fixes: nodejs/code-and-learn#58

@nanocloudx
doc: fix typo in doc/tls.md
44f0e61 
fix doc/tls.md: line 762 836 1026 e.g., => e.g.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Nov 12, 2016
addaleax
addaleax approved these changes Nov 12, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shigeki pushed a commit that referenced this pull request Nov 13, 2016
@nanocloudx @shigeki
doc: fix typo in doc/tls.md
9428854 
fix doc/tls.md: line 762 836 1026 e.g., => e.g.

Fixes: nodejs/code-and-learn#58
PR-URL: #9566
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
@shigeki
Copy link
Contributor

shigeki commented Nov 13, 2016

Thanks. Landed in 9428854.
Congrats on your first contribution to Node.

@shigeki shigeki closed this Nov 13, 2016
Fishrock123 pushed a commit that referenced this pull request Nov 22, 2016
@nanocloudx @Fishrock123
doc: fix typo in doc/tls.md
4098514 
fix doc/tls.md: line 762 836 1026 e.g., => e.g.

Fixes: nodejs/code-and-learn#58
PR-URL: #9566
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2016
@nanocloudx @MylesBorins
doc: fix typo in doc/tls.md
1bbc2c6 
fix doc/tls.md: line 762 836 1026 e.g., => e.g.

Fixes: nodejs/code-and-learn#58
PR-URL: #9566
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@nanocloudx @MylesBorins
doc: fix typo in doc/tls.md
7b08366 
fix doc/tls.md: line 762 836 1026 e.g., => e.g.

Fixes: nodejs/code-and-learn#58
PR-URL: #9566
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@shigeki shigeki shigeki approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code And Learn at NodeFest 2016
7 participants
@nanocloudx @shigeki @silverwind @addaleax @lpinca @MylesBorins @nodejs-github-bot